This repository was archived by the owner on May 22, 2024. It is now read-only.
remove SAFE_SLOTS_TO_UPDATE_JUSTIFIED#87
Merged
tersec merged 1 commit intoeth-clients:masterfrom Jun 14, 2023
Merged
Conversation
The `SAFE_SLOTS_TO_UPDATE_JUSTIFIED` constant is no longer used as the bouncing attack fix was removed: ethereum/consensus-specs#3290
parithosh
approved these changes
May 5, 2023
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 14, 2023
The `SAFE_SLOTS_TO_UPDATE_JUSTIFIED` constant is no longer used in any EF or Gnosis network metadata definitions. We can remove it. Upstream changes: - eth-clients/eth2-networks#87 - gnosischain/configs#10 Which we updated here: - #5071 - #5077
tersec
pushed a commit
to status-im/nimbus-eth2
that referenced
this pull request
Jun 14, 2023
The `SAFE_SLOTS_TO_UPDATE_JUSTIFIED` constant is no longer used in any EF or Gnosis network metadata definitions. We can remove it. Upstream changes: - eth-clients/eth2-networks#87 - gnosischain/configs#10 Which we updated here: - #5071 - #5077
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SAFE_SLOTS_TO_UPDATE_JUSTIFIEDconstant is no longer used as the bouncing attack fix was removed:ethereum/consensus-specs#3290